Generating overrides issue

[pro-anon]

Thank you for the bug report

• I am using the latest version of lsp-mode related packages.
• I checked FAQ and Troubleshooting sections
• You may also try reproduce the issue using clean environment using the following command: M-x lsp-start-plain

Bug description

This is csharp-mode with lsp as backend
I can't generate overrides using lsp-execute-code-action

This is the error it shows:

Debugger entered--Lisp error: (wrong-type-argument hash-table-p nil)
  lsp--execute-code-action(nil)
  lsp-execute-code-action(#<hash-table equal 2/2 0x155c434687a5>)
  funcall-interactively(lsp-execute-code-action #<hash-table equal 2/2 0x155c434687a5>)
  command-execute(lsp-execute-code-action)

Steps to reproduce

1. Open a C# project
2. Try to generate an override using lsp code actions
3. Error appears and no override method is generated

Expected behavior

Should show a list of methods that can be overridden, and then insert its signature in the editor upon selection.

Which Language Server did you use?

csharp-ls

OS

Linux

Error callstack

[Trace - 07:04:15 PM] Sending request 'textDocument/codeAction - (641)'.
Params: {
  "textDocument": {
    "uri": "file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs"
  },
  "range": {
    "start": {
      "line": 25,
      "character": 0
    },
    "end": {
      "line": 25,
      "character": 0
    }
  },
  "context": {
    "diagnostics": []
  }
}


[Trace - 07:04:15 PM] Received response 'textDocument/codeAction - (641)' in 13ms.
Result: [
  {
    "title": "Generate overrides...",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  },
  {
    "title": "Generate Equals(object)...",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  },
  {
    "title": "Generate Equals and GetHashCode...",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  },
  {
    "title": "Generate constructor 'ApplicationDbContext(options)'",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  },
  {
    "title": "Generate constructor 'ApplicationDbContext()'",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  },
  {
    "title": "Generate all",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  },
  {
    "title": "Generate constructor...",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  },
  {
    "title": "Add 'DebuggerDisplay' attribute",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  }
]


[Trace - 07:04:16 PM] Sending request 'codeAction/resolve - (642)'.
Params: {
  "title": "Generate overrides...",
  "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
}


[Trace - 07:04:16 PM] Received response 'codeAction/resolve - (642)' in 9ms.
Result: null


[Trace - 07:04:17 PM] Sending request 'textDocument/codeAction - (643)'.
Params: {
  "textDocument": {
    "uri": "file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs"
  },
  "range": {
    "start": {
      "line": 25,
      "character": 0
    },
    "end": {
      "line": 25,
      "character": 0
    }
  },
  "context": {
    "diagnostics": []
  }
}


[Trace - 07:04:17 PM] Received response 'textDocument/codeAction - (643)' in 38ms.
Result: [
  {
    "title": "Generate overrides...",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  },
  {
    "title": "Generate Equals(object)...",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  },
  {
    "title": "Generate Equals and GetHashCode...",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  },
  {
    "title": "Generate constructor 'ApplicationDbContext(options)'",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  },
  {
    "title": "Generate constructor 'ApplicationDbContext()'",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  },
  {
    "title": "Generate all",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  },
  {
    "title": "Generate constructor...",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  },
  {
    "title": "Add 'DebuggerDisplay' attribute",
    "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
  }
]

### Anything else?

_No response_

[yyoncho]

cc @razzmatazz

[razzmatazz]

hey @pro-anon which lsp server are you using, omnisharp or csharp-ls?

[razzmatazz]

oops, sorry; I see that you have that on your report..

[pro-anon]

@razzmatazz I don't think omnisharp supports code generation. Iirc it only had fixing imports/using statements as a code action

[pro-anon]

@razzmatazz does it work on your machine? It might be an issue with my config, I'm not sure. I'm using spacemacs

[razzmatazz]

It does work for me (doom emacs mostly, and vim sometimes), but in your case you hit some funny case where codeAction/resolve returns a null reponse..

[Trace - 07:04:16 PM] Sending request 'codeAction/resolve - (642)'.
Params: {
  "title": "Generate overrides...",
  "data": "{\"TextDocumentUri\":\"file:///home/<user>/HDD/Projects/MyProject/Data/ApplicationDbContext.cs\",\"Range\":{\"Start\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"End\":{\"Line\":25,\"Character\":0,\"DebuggerDisplay\":\"(25,0)\"},\"DebuggerDisplay\":\"(25,0)-(25,0)\"}}"
}


[Trace - 07:04:16 PM] Received response 'codeAction/resolve - (642)' in 9ms.
Result: null

Would it be possible to get reduced test case for this (a zip file with project contents)? Unless your project is open-source or a trivial?

[razzmatazz]

it can also be that generate overrides... is a code action that is not implemented currently.. actually let me check if that works on my machine:)

name for this code action could indicate that the action requires parameters to be specified for the code to be generated and we dont pass any..

[razzmatazz]

oh my... it really does not work; I will register this on csharp-ls repo:

• "Generate overrides..." code action always fails razzmatazz/csharp-language-server#36

will track the solution there

[razzmatazz]

if it is ok for you @pro-anon I am closing this as this is actually a bug in csharp-ls (sorry for transfering you to a second repo already today :E )

[pro-anon]

No problem