ts-ls: Wrong lsp-clients-typescript-server-path #4254

eginhard · 2023-12-09T19:40:47Z

Thank you for the bug report

I am using the latest version of lsp-mode related packages.
I checked FAQ and Troubleshooting sections
You may also try reproduce the issue using clean environment using the following command: M-x lsp-start-plain

Bug description

#4202 made some changes to handle a deprecated argument in the language server. This included changing lsp-clients-typescript-server-path() to return:

lsp-mode/clients/lsp-javascript.el

Line 803 in 01bd566

    
           (f-join (f-parent (lsp-package-path 'typescript)) "node_modules" "typescript" "lib"))))

For me this evaluates to ~/.emacs.d/var/lsp/server/npm/typescript/bin/node_modules/typescript/lib, while tsserver.js is actually in ~/.emacs.d/var/lsp/server/npm/typescript/lib/node_modules/typescript/lib. So I guess the line above should be:

(f-join (f-parent (f-parent (lsp-package-path 'typescript))) "lib" "node_modules" "typescript" "lib"))))

Steps to reproduce

Open a .js file with ts-ls, the following error appears: LSP :: Error from the Language Server: Request initialize failed with message: Could not find a valid TypeScript installation. Please ensure that the "typescript" dependency is installed in the workspace or that a valid tsserver.path is specified. Exiting. (Internal Error)

Expected behavior

ts-ls starts normally

Which Language Server did you use?

lsp-javascript/ts-ls

OS

Linux

Error callstack

No response

Anything else?

No response

The text was updated successfully, but these errors were encountered:

hamaker · 2023-12-19T11:48:48Z

I'm having this issue as well. Reverting the change from #4202 to line 803 resolved it.

yyoncho · 2023-12-19T15:21:29Z

@kiennq - seems like it is a regression?

ncaq · 2024-01-23T15:09:05Z

I am having a rather hard time getting lsp to work in a TypeScript project in a subdirectory due to this problem.
Also, the original PR does not work in environments that do not use node_modules such as yarn PnP, and I expect that some people will have trouble with that.

idhowardgj94 · 2024-02-05T13:00:25Z

I'm having this issue as well. Reverting the change from #4202 to line 803 resolved it.

same issue here, and resolved by follow @hamaker's suggestion.

I guess that new code didn't include all kind of npm install path.

For my case, I'm using nvm, and my global install path is in ~/.nvm/

And I can use M-x lsp-install-server command, and that tsc & tsserver bin install inside ~/.emacs.d/.cache/lsp/npm/typescript/bin

didn't really deep into what's going on here, though, hope someone can solve this problem :)

idhowardgj94 · 2024-02-05T13:16:24Z

try to dig deeper into the problem, I think that maybe not related to various of npm install path.

Maybe that logic just wrong in linux environment?

I thought that PR with the problem try to fix issue on window's version

Stop reading `node_modules` directly by the file system. The problem with this direct loading is that projects without `node_modules` in the top-level directory will not work at all. For example, when I develop with aws cdk, I cut off the `cdk` or `infra` directory and create a new `package.json` and put `node_modules` there too, but in that case, the code before this modification will not work at all. I solved this problem by simply inserting an abstraction layer. Relation. * [lsp-javascript: supply correct path to tsserver for ts-ls by kiennq · Pull Request emacs-lsp#4202 · emacs-lsp/lsp-mode](emacs-lsp#4202) * [ts-ls: Wrong lsp-clients-typescript-server-path · Issue emacs-lsp#4254 · emacs-lsp/lsp-mode](emacs-lsp#4254)

stradicat · 2024-03-05T19:58:41Z

I'm getting the same problem in (ubuntu) Linux; also:
Typescript specified through user setting ignored due to invalid path ..completely_wrong_path..

Deleting ~/.emacs.d/.cache/lsp/npm/typescript* and installing typescript and typescript-language-server globally mitigated the problem; the language server isn't being picked up under ~/.emacs.d/.cache/lsp, although eslint and other node-based servers are correctly detected.

This, however, does not happen in macOS; all language servers are correctly detected under ~/.emacs.d/.cache/lsp

hyperair · 2024-03-06T05:56:33Z

On my machine, my emacs.d cache folder looks like this:

~/.emacs.d/.cache/lsp/npm/typescript
├── bin
│   ├── tsc -> ../lib/node_modules/typescript/bin/tsc
│   └── tsserver -> ../lib/node_modules/typescript/bin/tsserver
└── lib
    └── node_modules
        └── typescript

5 directories, 2 files

Similar to the issue description, the elisp statement linked there evaluates to ~/.emacs.d/.cache/lsp/npm/typescript/bin/node_modules/typescript/lib which doesn't exist.

The fix in #4284 works for me, and as a quick workaround without having to locally edit my elpa files, adding a node_modules symlink in the path that lsp-mode is erroneously looking in also works:

$ cd ~/.emacs.d/.cache/lsp/npm/typescript/bin && ln -s ../lib/node_modules

ghferrari · 2024-03-12T12:09:45Z

I'm seeing this error on Debian Linux with Emacs 29.2. As a temporary workaround, I've created a symlink via

ln -s <path_prefix>/lsp/npm/typescript/lib/node_modules <path_prefix>/lsp/npm/typescript/bin

NB Amend <path_prefix> to suit the paths in your local installation and see the lsp-log error messages for the path where LSP is expecting to find the node_modules directory.

ncaq · 2024-03-14T22:52:40Z

My problem was solved by the PR I sent out last month, does this solve yours?
fix: remove direct references to the node_modules directory by ncaq · Pull Request #4333 · emacs-lsp/lsp-mode

jcs090218 · 2024-03-16T07:17:45Z

Can someone give this a test? 🤔 Thanks!

ghferrari · 2024-03-20T09:28:29Z

Thanks @ncaq - your PR seems to fix the problem for me.

jcs090218 · 2024-03-23T03:08:41Z

This doesn't look right. If you are on windows, the path looks like: 🤔

~/.emacs.d/.cache/lsp/npm/typescript/node_modules/typescript/lib

jcs090218 · 2024-03-24T00:24:21Z

Can someone test #4389? It should work on both Unix-like and Windows systems. 🤔

kiennq · 2024-03-24T11:02:27Z

Can someone test #4389? It should work on both Unix-like and Windows systems. 🤔

It looks good to me.

jcs090218 · 2024-03-24T18:20:55Z

Completed in #4389.

ncaq · 2024-03-27T08:25:29Z

I'm referencing the node_modules directory from the lsp root, so the problem isn't solved in environments with node_modules in subdirectories, etc. that my PR solved. should this be a separate issue?

ncaq · 2024-03-27T09:18:31Z

Perhaps you are under the mistaken impression that my PR is simply to change the PATH specification of the original issue contributor, while my PR is to stop referring to the PATH directly...
Well, I'll make sure it works on Windows.

ncaq · 2024-03-27T09:46:12Z

I have checked it works on Windows and found that it certainly does not work on Windows, even with the content of my PR, so I would like to correct it.

ncaq · 2024-03-27T13:49:39Z

@jcs090218
The problem was not completely resolved in my environment, but your point about it not working on Windows was correct, so I have corrected my submitted PR with reference to your correction as well.
I would be happy to review it for you.
fix: remove direct references to the node_modules directory by ncaq · Pull Request #4333 · emacs-lsp/lsp-mode

jcs090218 · 2024-03-27T22:28:43Z

I'm referencing the node_modules directory from the lsp root, so the problem isn't solved in environments with node_modules in subdirectories, etc. that my PR solved. should this be a separate issue?

It's better to be in separate issues. 👍 The title is a bit misleading. 🤔

* fix: remove direct references to the node_modules directory Stop reading `node_modules` directly by the file system. The problem with this direct loading is that projects without `node_modules` in the top-level directory will not work at all. For example, when I develop with aws cdk, I cut off the `cdk` or `infra` directory and create a new `package.json` and put `node_modules` there too, but in that case, the code before this modification will not work at all. I solved this problem by simply inserting an abstraction layer. Relation. * [lsp-javascript: supply correct path to tsserver for ts-ls by kiennq · Pull Request #4202 · emacs-lsp/lsp-mode](#4202) * [ts-ls: Wrong lsp-clients-typescript-server-path · Issue #4254 · emacs-lsp/lsp-mode](#4254) * fix(lsp-javascript): remove shell redirect when call node In the case of Windows, etc., `shell-command-to-string` is to use a non-bash shell. To begin with, `shell-command-to-string` seems to ignore standard error output. * refactor(lsp-javascript): rename function and add docs `lsp-clients-typescript-server-path-by-node-require` is too long. * fix(lsp-javascript): use Node.js require to explore Pros === Since Node.js require indicates the path where the file actually exists, it automatically adapts to various environments unless there are significant system changes or changes in the usage environment. Cons === There is a small overhead at first startup due to the command execution. * refactor: use `if-let*` and `when-let*` Simplified based on code review.

…p#4333) * fix: remove direct references to the node_modules directory Stop reading `node_modules` directly by the file system. The problem with this direct loading is that projects without `node_modules` in the top-level directory will not work at all. For example, when I develop with aws cdk, I cut off the `cdk` or `infra` directory and create a new `package.json` and put `node_modules` there too, but in that case, the code before this modification will not work at all. I solved this problem by simply inserting an abstraction layer. Relation. * [lsp-javascript: supply correct path to tsserver for ts-ls by kiennq · Pull Request emacs-lsp#4202 · emacs-lsp/lsp-mode](emacs-lsp#4202) * [ts-ls: Wrong lsp-clients-typescript-server-path · Issue emacs-lsp#4254 · emacs-lsp/lsp-mode](emacs-lsp#4254) * fix(lsp-javascript): remove shell redirect when call node In the case of Windows, etc., `shell-command-to-string` is to use a non-bash shell. To begin with, `shell-command-to-string` seems to ignore standard error output. * refactor(lsp-javascript): rename function and add docs `lsp-clients-typescript-server-path-by-node-require` is too long. * fix(lsp-javascript): use Node.js require to explore Pros === Since Node.js require indicates the path where the file actually exists, it automatically adapts to various environments unless there are significant system changes or changes in the usage environment. Cons === There is a small overhead at first startup due to the command execution. * refactor: use `if-let*` and `when-let*` Simplified based on code review.

eginhard added the bug label Dec 9, 2023

eginhard mentioned this issue Jan 3, 2024

fix(ts-ls): incorrect typescript server path #4284

Closed

ncaq mentioned this issue Feb 14, 2024

fix: remove direct references to the node_modules directory #4333

Merged

alexey0308 mentioned this issue Feb 16, 2024

[JS/TS] LSP :: Error from the Language Server: Request initialize failed with message: Could not find a valid TypeScript installation. Please ensure that the "typescript" dependency is installed in the workspace... syl20bnr/spacemacs#16286

Closed

jcs090218 mentioned this issue Mar 23, 2024

fix(ts-ls): node_modules has different path on different platforms #4389

Merged

jcs090218 closed this as completed Mar 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ts-ls: Wrong lsp-clients-typescript-server-path #4254

ts-ls: Wrong lsp-clients-typescript-server-path #4254

eginhard commented Dec 9, 2023

hamaker commented Dec 19, 2023 •

edited

yyoncho commented Dec 19, 2023

ncaq commented Jan 23, 2024

idhowardgj94 commented Feb 5, 2024

idhowardgj94 commented Feb 5, 2024

stradicat commented Mar 5, 2024 •

edited

hyperair commented Mar 6, 2024

ghferrari commented Mar 12, 2024

ncaq commented Mar 14, 2024

jcs090218 commented Mar 16, 2024

ghferrari commented Mar 20, 2024

jcs090218 commented Mar 23, 2024

jcs090218 commented Mar 24, 2024

kiennq commented Mar 24, 2024

jcs090218 commented Mar 24, 2024

ncaq commented Mar 27, 2024

ncaq commented Mar 27, 2024

ncaq commented Mar 27, 2024

ncaq commented Mar 27, 2024

jcs090218 commented Mar 27, 2024

ts-ls: Wrong lsp-clients-typescript-server-path #4254

ts-ls: Wrong lsp-clients-typescript-server-path #4254

Comments

eginhard commented Dec 9, 2023

Thank you for the bug report

Bug description

Steps to reproduce

Expected behavior

Which Language Server did you use?

OS

Error callstack

Anything else?

hamaker commented Dec 19, 2023 • edited

yyoncho commented Dec 19, 2023

ncaq commented Jan 23, 2024

idhowardgj94 commented Feb 5, 2024

idhowardgj94 commented Feb 5, 2024

stradicat commented Mar 5, 2024 • edited

hyperair commented Mar 6, 2024

ghferrari commented Mar 12, 2024

ncaq commented Mar 14, 2024

jcs090218 commented Mar 16, 2024

ghferrari commented Mar 20, 2024

jcs090218 commented Mar 23, 2024

jcs090218 commented Mar 24, 2024

kiennq commented Mar 24, 2024

jcs090218 commented Mar 24, 2024

ncaq commented Mar 27, 2024

ncaq commented Mar 27, 2024

ncaq commented Mar 27, 2024

ncaq commented Mar 27, 2024

jcs090218 commented Mar 27, 2024

hamaker commented Dec 19, 2023 •

edited

stradicat commented Mar 5, 2024 •

edited