Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a timeout on server replies #66

Closed
alanz opened this issue Apr 24, 2017 · 5 comments
Closed

Need a timeout on server replies #66

alanz opened this issue Apr 24, 2017 · 5 comments

Comments

@alanz
Copy link
Contributor

alanz commented Apr 24, 2017

At the moment the emacs UI hangs for as long as the server is processing a message.

This should preferable become async, or should have some means to interrupt, or timeout.

@mattiasb
Copy link

This is probably what I've been experiencing with several modes. Emacs appears to hang, but it's just an effect of the synchronous nature of the RPC implementation then I guess.

@vibhavp
Copy link
Member

vibhavp commented Apr 24, 2017

The problem here is that lsp-mode is designed to plug into already existing emacs interfaces. As long as they're not asynchronous, we can't make lsp-mode async. However, a timeout is feasible.

@s-kostyaev
Copy link
Contributor

@vibhavp you can do it with some tricks like this s-kostyaev/ivy-erlang-complete@1dcb258

vibhavp added a commit that referenced this issue Apr 30, 2017
@vibhavp
Copy link
Member

vibhavp commented Apr 30, 2017

The current timeout value is 10 seconds. Is that fine, or should I further lower it?

@alanz
Copy link
Contributor Author

alanz commented Apr 30, 2017

That is probably fine.

The problem is that some commands (for haskell anyway) can potentially run for a long time.

So some sort of async processing would be ideal. But let's see how this works out.

After all, this should only be triggered if there is a problem on the server, in my experience.

@vibhavp vibhavp closed this as completed May 4, 2017
renatofdds pushed a commit to renatofdds/lsp-mode that referenced this issue May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants