Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compile error "Unknown rx symbol 'char'" " after emacs rewrite to rx library. #1052

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

davidwelch158
Copy link
Contributor

Use 'anything' to match any character in the file basename.
The rewrite was this commit: emacs-mirror/emacs@2ed7122

…ed71227c626c6cfdc684948644ccf3d9eaeb15b which rewrote the rx library. Use 'anything' to match any character in the file basename.
@yyoncho
Copy link
Member

yyoncho commented Sep 27, 2019

Have you tested this on emacs 25/26?

@davidwelch158
Copy link
Contributor Author

Have you tested this on emacs 25/26?

Yes, 'anything' works on emacs 25.

@davidwelch158 davidwelch158 reopened this Sep 27, 2019
@yyoncho yyoncho merged commit 86d3a8e into emacs-lsp:master Sep 27, 2019
@yyoncho
Copy link
Member

yyoncho commented Sep 27, 2019

Thank you and congrats for your first lsp-mode PR! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants