Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature posframe support #1999

Merged
merged 1 commit into from Jan 26, 2021
Merged

Signature posframe support #1999

merged 1 commit into from Jan 26, 2021

Conversation

yyoncho
Copy link
Member

@yyoncho yyoncho commented Aug 5, 2020


Copy link
Member

@ericdallo ericdallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ericdallo ericdallo added this to Review in lsp-mode via automation Aug 13, 2020
@ericdallo ericdallo added this to the Next release milestone Aug 13, 2020
@muirdm
Copy link
Contributor

muirdm commented Aug 17, 2020

Looks cool. The posframe seemed to bounce around with point - can it stay anchored to the start of the function call? I also had trouble customizing the colors on the posframe. I customized tooltip face, but it didn't really work.

@yyoncho
Copy link
Member Author

yyoncho commented Aug 17, 2020

  • can it stay anchored to the start of the function call?

The server does not provide that data. VScode also moves the popup.

I also had trouble customizing the colors on the posframe. I customized tooltip face, but it didn't really work.

I will expose the posframe params before merging.

@kiennq
Copy link
Member

kiennq commented Jan 8, 2021

@yyoncho Is there any other problem for this?

@yyoncho
Copy link
Member Author

yyoncho commented Jan 8, 2021

@yyoncho Is there any other problem for this?

I think that I was planning to add some customization which is not possible ATM.

@FelipeLema
Copy link
Contributor

is this posframe displayed on request? on timeout? both? either?

@yyoncho
Copy link
Member Author

yyoncho commented Jan 18, 2021

is this posframe displayed on request? on timeout? both? either?

When you press signatureHelp triggerChar (e. g. ()/

@yyoncho yyoncho changed the title (WIP) Signature posframe support Signature posframe support Jan 26, 2021
@yyoncho
Copy link
Member Author

yyoncho commented Jan 26, 2021

I tested the latest version and it seems like it is working fine, except the fact that you cannot scroll the signature window screen(which will be addressed).

@yyoncho yyoncho merged commit 86f6529 into emacs-lsp:master Jan 26, 2021
lsp-mode automation moved this from Review to Done Jan 26, 2021
@benbot
Copy link
Contributor

benbot commented Jul 26, 2021

except the fact that you cannot scroll the signature window screen

@yyoncho Is there anywhere tracking that work?

@yyoncho
Copy link
Member Author

yyoncho commented Jul 26, 2021

except the fact that you cannot scroll the signature window screen

@yyoncho Is there anywhere tracking that work?

@benbot afaik no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
lsp-mode
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants