-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rust-Analyzer reload workspace command #2728
Merged
yyoncho
merged 3 commits into
emacs-lsp:master
from
nightkr:feature/rust-analyzer/reload-workspace
Mar 20, 2021
Merged
Add Rust-Analyzer reload workspace command #2728
yyoncho
merged 3 commits into
emacs-lsp:master
from
nightkr:feature/rust-analyzer/reload-workspace
Mar 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets Rust-Analyzer pick up project changes without a full server restart.
github-actions
bot
added
client
One or more of lsp-mode language clients
documentation
rust
labels
Mar 19, 2021
ericdallo
reviewed
Mar 19, 2021
Co-authored-by: Eric Dallo <ercdll1337@gmail.com>
ericdallo
approved these changes
Mar 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://github.com/emacs-lsp/lsp-mode/runs/2148282265 looks more like a test infra problem than something related to this PR, as far as I can see? |
Yes an out of memory error it seems, I retriggered the CI |
nightkr
added a commit
to nightkr/spacemacs
that referenced
this pull request
Mar 19, 2021
See emacs-lsp/lsp-mode#2728 for motivation, should not be merged before that is.
nightkr
added a commit
to nightkr/spacemacs
that referenced
this pull request
Mar 19, 2021
Allows you to pick up new Cargo dependencies without a (slooow) full server restart. See emacs-lsp/lsp-mode#2728
yyoncho
approved these changes
Mar 20, 2021
Thank you! |
smile13241324
pushed a commit
to syl20bnr/spacemacs
that referenced
this pull request
Mar 20, 2021
Allows you to pick up new Cargo dependencies without a (slooow) full server restart. See emacs-lsp/lsp-mode#2728 Add diagnostic messages when trying to reload RA workspace No point restarting when trying to reload RLS
aam-at
pushed a commit
to aam-at/spacemacs
that referenced
this pull request
Mar 23, 2021
Allows you to pick up new Cargo dependencies without a (slooow) full server restart. See emacs-lsp/lsp-mode#2728 Add diagnostic messages when trying to reload RA workspace No point restarting when trying to reload RLS
wang-d
pushed a commit
to wang-d/spacemacs
that referenced
this pull request
Jul 22, 2021
Allows you to pick up new Cargo dependencies without a (slooow) full server restart. See emacs-lsp/lsp-mode#2728 Add diagnostic messages when trying to reload RA workspace No point restarting when trying to reload RLS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets Rust-Analyzer pick up project changes without a full server restart.