Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust-Analyzer reload workspace command #2728

Merged

Conversation

nightkr
Copy link
Contributor

@nightkr nightkr commented Mar 19, 2021

This lets Rust-Analyzer pick up project changes without a full server restart.

This lets Rust-Analyzer pick up project changes without a full server restart.
@github-actions github-actions bot added client One or more of lsp-mode language clients documentation rust labels Mar 19, 2021
Co-authored-by: Eric Dallo <ercdll1337@gmail.com>
Copy link
Member

@ericdallo ericdallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nightkr
Copy link
Contributor Author

nightkr commented Mar 19, 2021

https://github.com/emacs-lsp/lsp-mode/runs/2148282265 looks more like a test infra problem than something related to this PR, as far as I can see?

@ericdallo
Copy link
Member

Yes an out of memory error it seems, I retriggered the CI

nightkr added a commit to nightkr/spacemacs that referenced this pull request Mar 19, 2021
See emacs-lsp/lsp-mode#2728 for motivation,
should not be merged before that is.
nightkr added a commit to nightkr/spacemacs that referenced this pull request Mar 19, 2021
Allows you to pick up new Cargo dependencies without a (slooow)
full server restart.

See emacs-lsp/lsp-mode#2728
@yyoncho yyoncho merged commit 21869b6 into emacs-lsp:master Mar 20, 2021
@yyoncho
Copy link
Member

yyoncho commented Mar 20, 2021

Thank you!

smile13241324 pushed a commit to syl20bnr/spacemacs that referenced this pull request Mar 20, 2021
Allows you to pick up new Cargo dependencies without a (slooow)
full server restart.

See emacs-lsp/lsp-mode#2728

Add diagnostic messages when trying to reload RA workspace

No point restarting when trying to reload RLS
aam-at pushed a commit to aam-at/spacemacs that referenced this pull request Mar 23, 2021
Allows you to pick up new Cargo dependencies without a (slooow)
full server restart.

See emacs-lsp/lsp-mode#2728

Add diagnostic messages when trying to reload RA workspace

No point restarting when trying to reload RLS
wang-d pushed a commit to wang-d/spacemacs that referenced this pull request Jul 22, 2021
Allows you to pick up new Cargo dependencies without a (slooow)
full server restart.

See emacs-lsp/lsp-mode#2728

Add diagnostic messages when trying to reload RA workspace

No point restarting when trying to reload RLS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients documentation rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants