rust: add rust-analyzer option to unset #[cfg(test)] in specified crates #3156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows the user to still enable #[cfg(test)] in rust-analyzer
globally while not breaking dependencies that have different (broken)
behavior when #[cfg(test)] is set.
see:
- rust-lang/rust-analyzer#7225
- lf-/rust-analyzer@86c9e7b
cassandracomar
force-pushed
the
rust-analyzer-unset-cfg-test
branch
from
b5c33ce
to
751d8b8
Compare
kiennq
reviewed
Oct 19, 2021
| "force rust-analyzer to unset `#[cfg(test)]` for the specified crates." | ||
| :type 'lsp-string-vector | ||
| :group 'lsp-rust-analyzer | ||
| :package-version '(lsp-mode . "6.2.2")) |
There was a problem hiding this comment.
The package version should be something higher 8.0.1
|
Can we get this merged? Why is the CI failing? Seems to be some CMake issue unrelated to this PR. My current rust project needs to unset cfg test so that RA works properly. |
|
@vikigenius done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows the user to still enable #[cfg(test)] in rust-analyzer
globally while not breaking dependencies that have different (broken)
behavior when #[cfg(test)] is set.
see:
- rust-lang/rust-analyzer#7225
- lf-/rust-analyzer@86c9e7b