lsp-csharp.el: fix breakage with the latest emacs #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyoncho
approved these changes
Feb 12, 2022
|
@yyoncho I have applied a couple more commits to make this PR even better :) |
yyoncho
approved these changes
Feb 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://lists.gnu.org/archive/html/emacs-devel/2022-02/msg00461.html
for more context.
I will provide a corresponding PR for lsp-fsharp later too.
I didn't hear other runtimes than dotnet experiencing issues with a switch to posix_spawn in emacs, but just FYI -- the latest emacs@master (@emacs-28 on macos too) launches subprocesses with SIGCHLD and other signals masked and unless subprocess fixes it up by itself, that may cause problems.