add :features to checkOnSave and use original descriptions #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs090218
approved these changes
Jan 5, 2023
brotzeit
changed the title
otavio
approved these changes
Jan 5, 2023
yyoncho
approved these changes
Jan 5, 2023
|
how was that even working without this change?! |
instead of using the same as rls. Also remove deprecated configuration option :allTargets
|
rust-analyzer changes configuration options very frequently. In the past there was |
What does this mean? Maybe there's a confusion because I would suggest adding (Ideally we should probably also rename |
ia0
added a commit
to ia0/lsp-mode
that referenced
this pull request
Feb 25, 2023
This partially reverts emacs-lsp#3893. The rust-analyzer.checkOnSave.allTargets configuration still exists, although it is internally renamed by rust-analyzer to rust-analyzer.check.allTargets which is the new version. Maybe the intent was to remove lsp-rust-all-targets which is indeed unused by lsp-rust.
brotzeit
pushed a commit
that referenced
this pull request
Feb 26, 2023
This partially reverts #3893. The rust-analyzer.checkOnSave.allTargets configuration still exists, although it is internally renamed by rust-analyzer to rust-analyzer.check.allTargets which is the new version. Maybe the intent was to remove lsp-rust-all-targets which is indeed unused by lsp-rust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.