Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hierarchical document symbols #421

Merged
merged 1 commit into from Sep 15, 2018

Conversation

tigersoldier
Copy link
Contributor

LSP introduced hierarchical DocumentSymbol message to support hierarchical
outlines. Set hierarchicalDocumentSymbolSupport to true in the client
capabilities and handle DocumentSymbol messages in lsp-imenu.

Also fixed some document symbol bugs.

@MaskRay
Copy link
Member

MaskRay commented Sep 13, 2018

@bizzyman

hooray to see this and emacs-lsp/lsp-ui#179 I'll consider adding DocumentSymbol[] support in ccls.

It isn't very straightforward to me how to do that because declarations in C++ can be repeated (redeclarable) and there are both semantic and lexical parents.

namespace ns {
class A {
  void out_of_line();
};
void A::out_of_line() {
}
}

// redeclarable
namespace ns { int foo; }
namespace ns { int bar; }

lsp-imenu.el Show resolved Hide resolved
lsp-imenu.el Outdated Show resolved Hide resolved
Copy link
Member

@MaskRay MaskRay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

LSP introduced hierarchical DocumentSymbol message to support hierarchical
outlines. Set hierarchicalDocumentSymbolSupport to true in the client
capabilities and handle DocumentSymbol messages in lsp-imenu.

Also fixed some document symbol bugs.
@vibhavp
Copy link
Member

vibhavp commented Sep 15, 2018

Thanks!

@vibhavp vibhavp merged commit 601bf6d into emacs-lsp:master Sep 15, 2018
wkirschbaum pushed a commit to wkirschbaum/lsp-mode that referenced this pull request Jun 1, 2021
kerl and kiex are not officially supported as a way to manage the
installed Elixir and Erlang versions.

Fixes emacs-lsp#414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants