Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight active parameter with face eldoc-highlight-function-argument #422

Merged
merged 1 commit into from Sep 15, 2018

Conversation

MaskRay
Copy link
Member

@MaskRay MaskRay commented Sep 11, 2018

int foo(int a, int b, int c = 7) {
  return a+ b + c;
}

int main() {
  foo(1, 2<point>, 3);
}

In ccls, this was rendered as foo(int a, int b, int c = 7) -> int before, and now foo(int a, <strong>int b</strong>, int c = 7) -> int.

Similar approaches are used by

LanguageClient-neovim src/languageclient.rs

eglot (but it trims the signature label (propertize (replace-regexp-in-string "(.*$" "(" label) which will remove -> return_type)

@MaskRay
Copy link
Member Author

MaskRay commented Sep 11, 2018

BTW, (defun lsp--text-document-signature-help () ...) only takes effect when (symbol-at-point)is notnil. This does not work well for foo(arg0, ` (when there is no symbol in the argument position)

@vibhavp
Copy link
Member

vibhavp commented Sep 15, 2018

Thanks.

@vibhavp vibhavp merged commit d811e7a into emacs-lsp:master Sep 15, 2018
wkirschbaum pushed a commit to wkirschbaum/lsp-mode that referenced this pull request Jun 1, 2021
* avoid another pass over enumerable

* avoid expand_references on the same modules if they are used in more than 1 app

avoid getting path from module when path is already known

* add always started otp apps to plt

before they were included indirectly as elixir app deps
not all modules from those apps were analyzed

* prefer consolidated protocol beams

* avoid unnecessary passes over map

* run formatter

* avoid another iterations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants