Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsp-ui breaks with display line numbers enabled in emacs 26 #96

Closed
maplant opened this issue Mar 15, 2018 · 2 comments
Closed

lsp-ui breaks with display line numbers enabled in emacs 26 #96

maplant opened this issue Mar 15, 2018 · 2 comments

Comments

@maplant
Copy link
Contributor

maplant commented Mar 15, 2018

lsp-ui formatting breaks with lsp-ui-sideline and lsp-ui-doc when display-line-numbers-mode is enabled in emacs 26.

Seems to be an issue calculating the offset of the sideline text. I'll take a look at it after work

With display-line-numbers-mode enabled:
screen shot 2018-03-15 at 10 35 11 am

With display-line-numbers-mode disabled:
screen shot 2018-03-15 at 10 35 52 am
@twlz0ne
Copy link
Contributor

twlz0ne commented Mar 19, 2018 •
edited
Loading

I have the same issue under the terminal.

No matter how wide the window is, there is always line breaks:

screen shot 2018-03-16 at 10 41 56 am
screen shot 2018-03-19 at 10 59 24 am

I created a PR to fix it: #97

@maplant
Copy link
Contributor Author

maplant commented Mar 20, 2018

I created a similar fix in the lsp-ui-sideline: #103

@Flinner Flinner mentioned this issue Mar 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maplant @twlz0ne @sebastiencs