Fixed some UI issues. #6

devio · 2016-08-01T22:05:59Z

Fixed some annoying issues with the Emacs user-interface. Some of
these fixes may also affect Emacs core, but at least it works for
me. --ths

Fixed some annoying issues with the Emacs user-interface. Some of these fixes may also affect Emacs core, but at least it works for me. --ths

jjasghar · 2016-08-01T22:20:17Z

Very funny. 😞

17:19:13 JJs-MacBook-Pro emacs > (master) hub checkout https://github.com/emacs-mirror/emacs/pull/6
Updating devio
remote: Counting objects: 2808, done.
remote: Compressing objects: 100% (2739/2739), done.
remote: Total 2808 (delta 253), reused 0 (delta 0), pack-reused 1
Receiving objects: 100% (2808/2808), 12.26 MiB | 7.12 MiB/s, done.
Resolving deltas: 100% (253/253), done.
From git://github.com/devio/emacs
 * [new branch]      master     -> devio/master
Branch devio-master set up to track remote branch master from devio by rebasing.
Switched to a new branch 'devio-master'
17:19:22 JJs-MacBook-Pro emacs > (devio-master) ls
CONTRIBUTING.md README.md       appveyor.yml    nsis            src             vimtutor.com
Filelist        README.txt      configure       pixmaps         uninstal.txt
Makefile        READMEdir       farsi           runtime         vimtutor.bat
17:19:23 JJs-MacBook-Pro emacs > (devio-master)

devio · 2016-08-01T22:46:52Z

c'mon.. it's just two clicks :-)

jjasghar · 2016-08-01T22:47:45Z

You should take a look at: http://spacemacs.org/ it's the best of both worlds 🤘

The recent changes to src/casefiddle.c cause build failure as seen below: Starting program: /home/npostavs/src/emacs/emacs-bootstrapping/src/temacs --batch --load loadup bootstrap [Thread debugging using libthread_db enabled] Using host libthread_db library "/usr/lib/libthread_db.so.1". Loading loadup.el (source)... Using load-path (/home/npostavs/src/emacs/emacs-bootstrapping/lisp /home/npostavs/src/emacs/emacs-bootstrapping/lisp/emacs-lisp /home/npostavs/src/emacs/emacs-bootstrapping/lisp/language /home/npostavs/src/emacs/emacs-bootstrapping/lisp/international /home/npostavs/src/emacs/emacs-bootstrapping/lisp/textmodes /home/npostavs/src/emacs/emacs-bootstrapping/lisp/vc) Loading emacs-lisp/byte-run (source)... Loading emacs-lisp/backquote (source)... Loading subr (source)... Loading version (source)... Loading widget (source)... Loading custom (source)... Loading emacs-lisp/map-ynp (source)... Loading international/mule (source)... Loading international/mule-conf (source)... lread.c:3914: Emacs fatal error: assertion failed: !NILP (Vpurify_flag) Breakpoint 1, terminate_due_to_signal at emacs.c:363 363 signal (sig, SIG_DFL); (gdb) bt #0 0x0000000000579826 in terminate_due_to_signal at emacs.c:363 #1 0x000000000060ec33 in die at alloc.c:7352 #2 0x000000000066db40 in intern_c_string_1 at lread.c:3914 #3 0x0000000000576884 in intern_c_string at lisp.h:3790 #4 0x00000000005dc84f in prepare_casing_context at casefiddle.c:69 #5 0x00000000005dd37f in casify_object at casefiddle.c:311 #6 0x00000000005dd47f in Fcapitalize at casefiddle.c:356 #7 0x00000000006325ac in eval_sub at eval.c:2219 #8 0x0000000000632368 in eval_sub at eval.c:2184 #9 0x000000000063446c in apply_lambda at eval.c:2875 #10 0x00000000006329af in eval_sub at eval.c:2294 #11 0x000000000062d462 in Fprogn at eval.c:449 #12 0x000000000062d4cf in prog_ignore at eval.c:461 #13 0x000000000062f19c in Fwhile at eval.c:982 #14 0x00000000006321f4 in eval_sub at eval.c:2172 #15 0x000000000062d462 in Fprogn at eval.c:449 #16 0x000000000062f0c4 in Flet at eval.c:963 #17 0x00000000006321f4 in eval_sub at eval.c:2172 #18 0x0000000000632963 in eval_sub at eval.c:2290 #19 0x000000000062d462 in Fprogn at eval.c:449 #20 0x000000000062f0c4 in Flet at eval.c:963 #21 0x00000000006321f4 in eval_sub at eval.c:2172 #22 0x0000000000668caa in readevalloop at lread.c:1927 #23 0x0000000000667253 in Fload at lread.c:1332 #24 0x0000000000632683 in eval_sub at eval.c:2233 #25 0x0000000000668caa in readevalloop at lread.c:1927 #26 0x0000000000667253 in Fload at lread.c:1332 #27 0x0000000000632683 in eval_sub at eval.c:2233 #28 0x0000000000631be5 in Feval at eval.c:2041 #29 0x000000000057e1af in top_level_2 at keyboard.c:1121 #30 0x000000000062ffc7 in internal_condition_case at eval.c:1324 #31 0x000000000057e1f0 in top_level_1 at keyboard.c:1129 #32 0x000000000062f51e in internal_catch at eval.c:1091 #33 0x000000000057e0ea in command_loop at keyboard.c:1090 #34 0x000000000057d6d5 in recursive_edit_1 at keyboard.c:697 #35 0x000000000057d8b4 in Frecursive_edit at keyboard.c:768 #36 0x000000000057b55b in main at emacs.c:1687 Lisp Backtrace: "capitalize" (0xffffcf70) "format" (0xffffd130) "define-charset" (0xffffd370) "while" (0xffffd560) "let" (0xffffd7c0) "dolist" (0xffffd910) "let" (0xffffdb70) "load" (0xffffdfe0) "load" (0xffffe4a0) * src/casefiddle.c (syms_of_casefiddle): Declare four new symbols: Qtitlecase, Qspecial_uppercase, Qspecial_lowercase and Qspecial_titlecase. (prepare_casing_context): Use aforementioned symbols.

raviskit · 2018-01-15T06:18:52Z

Bravo @devio. Hell of a Job. Changing 6357 files and committing as some UI issues fixed.
basically changing emacs to vim. Best developer revenge who hate emacs.

PratikDeoghare · 2018-01-15T13:13:36Z

lgtm

elliotec · 2018-01-15T23:16:41Z

Can this go in yet? I know a lot of people that can't wait!

NicolasPetton · 2018-01-16T16:04:21Z

Can you fix your conflicts with master?

alfasin · 2018-01-17T22:41:59Z

Finally somebody did it...
:)

imcsk8 · 2018-01-18T18:36:18Z

LGTM!

anxolerd

Wow dude, that is hell of a work done here!

:wq

denqxotl · 2018-02-05T12:27:53Z

👍 useful changes

telmich · 2018-02-22T11:29:38Z

@devio I tried to use it, but somehow my .emacs config is not read anymore. Can you fix that in your patch?

Also, on my screen there are a lot of snakes, is it possible you added that patch in the jungle?

Oh, and one tiny last problem: I cannot type text anymore, is that the intended behaviour?

Otherwise, great UI changes! Love it! Will install it on all our servers!

harryfei · 2018-10-06T05:01:40Z

How to quit my new Emacs?

luksamuk · 2018-11-09T15:30:08Z

There is something wrong with this patch. org-mode and elfeed do not seem to work, and I cannot exit Emacs anymore. Please fix these issues.

ghost · 2018-11-13T04:38:39Z

🤦

how is this not #closed

safiyat

Please resolve the conflicts.

PatrickWolleb · 2018-12-13T12:41:12Z

Can someone merge this please. We relying on this for business critical app.

Enable harfbuzz for pgtk options

Julius2342 · 2022-09-29T10:26:08Z

Ultimate customer https://emacs.my.salesforce.com/0012101001EXliJ is requesting this feature.

Fixed some UI issues.

065f9e4

Fixed some annoying issues with the Emacs user-interface. Some of these fixes may also affect Emacs core, but at least it works for me. --ths

ghost approved these changes Jan 15, 2018

View reviewed changes

elliotec approved these changes Jan 15, 2018

View reviewed changes

corevo approved these changes Jan 18, 2018

View reviewed changes

ValkoVolodya approved these changes Jan 26, 2018

View reviewed changes

anxolerd approved these changes Jan 26, 2018

View reviewed changes

safiyat suggested changes Nov 13, 2018

View reviewed changes

kiprasmel approved these changes Dec 30, 2019

View reviewed changes

pranjal9599 approved these changes Dec 31, 2019

View reviewed changes

flatwhatson pushed a commit to flatwhatson/emacs that referenced this pull request Nov 23, 2020

Merge pull request emacs-mirror#6 from fejfighter/pgtk-harfbuzz

f28489e

Enable harfbuzz for pgtk options

khrj approved these changes Nov 29, 2020

View reviewed changes

tejasvi approved these changes Mar 20, 2021

View reviewed changes

00-matt mentioned this pull request Dec 27, 2021

Tree sitter integration is not triggering casouri/emacs#3

Open

ivan-developer-01 approved these changes Sep 30, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed some UI issues. #6

Fixed some UI issues. #6

devio commented Aug 1, 2016

jjasghar commented Aug 1, 2016

devio commented Aug 1, 2016

jjasghar commented Aug 1, 2016

raviskit commented Jan 15, 2018

PratikDeoghare commented Jan 15, 2018

elliotec commented Jan 15, 2018

NicolasPetton commented Jan 16, 2018

alfasin commented Jan 17, 2018

imcsk8 commented Jan 18, 2018

anxolerd left a comment

denqxotl commented Feb 5, 2018

telmich commented Feb 22, 2018

harryfei commented Oct 6, 2018

luksamuk commented Nov 9, 2018

ghost commented Nov 13, 2018

safiyat left a comment

PatrickWolleb commented Dec 13, 2018

Julius2342 commented Sep 29, 2022

Fixed some UI issues. #6

Are you sure you want to change the base?

Fixed some UI issues. #6

Conversation

devio commented Aug 1, 2016

jjasghar commented Aug 1, 2016

devio commented Aug 1, 2016

jjasghar commented Aug 1, 2016

raviskit commented Jan 15, 2018

PratikDeoghare commented Jan 15, 2018

elliotec commented Jan 15, 2018

NicolasPetton commented Jan 16, 2018

alfasin commented Jan 17, 2018

imcsk8 commented Jan 18, 2018

anxolerd left a comment

Choose a reason for hiding this comment

denqxotl commented Feb 5, 2018

telmich commented Feb 22, 2018

harryfei commented Oct 6, 2018

luksamuk commented Nov 9, 2018

ghost commented Nov 13, 2018

safiyat left a comment

Choose a reason for hiding this comment

PatrickWolleb commented Dec 13, 2018

Julius2342 commented Sep 29, 2022