Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable travis-ci #168

Closed
wants to merge 1 commit into from
Closed

Enable travis-ci #168

wants to merge 1 commit into from

Conversation

syohex
Copy link
Collaborator

@syohex syohex commented Sep 1, 2014

  • Add travis configuration file
  • Fix test for older Emacs(<= 24.3).

Because font-lock-add-keywords does not work in batch-mode on older Emacs.

- Add travis configuration file
- Fix test for older Emacs(<= 24.3).

Because font-lock-add-keywords does not work in batch-mode on older Emacs.
@syohex
Copy link
Collaborator Author

syohex commented Sep 1, 2014

Please enable CI if this pull request is merged.

@ejmr
Copy link
Collaborator

ejmr commented Sep 1, 2014

Thank you. I've merged your patch as 3d1f0a3. I am going to setup Travis CI as well.

@ejmr ejmr closed this Sep 1, 2014
@jorissteyn
Copy link
Contributor

Nice. I've merged these changes into my cc-mode branch.

FYI: I had to (require 'cl) in php-mode.el in order to get a pass on emacs-snapshot. Output of failure here: https://travis-ci.org/jorissteyn/php-mode/jobs/34121887.

@syohex
Copy link
Collaborator Author

syohex commented Sep 2, 2014

You should remove eval-when-compile around (require 'cl) or should switch to
cl-lib and use cl-set-difference instead of set-difference.

@syohex syohex deleted the enable-travis-ci branch September 2, 2014 03:20
@jorissteyn
Copy link
Contributor

Ah I see, thanks. I'll put a reminder in #66 to get this fixed there, sooner or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants