Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight the ? character for nullable type hints and return types #482

Merged
merged 1 commit into from Aug 29, 2018

Conversation

fabacino
Copy link
Contributor

I changed all the tests to expect the highlighting of the ? character to be the one of a data type.

Fixes #469

@ejmr
Copy link
Collaborator

ejmr commented Aug 28, 2018

@syohex

Feel free to add to the merge commit message:

Reviewed-by: Eric James Michael Ritz.

In the future I'll simply post the above Reviewed-by line for any patch I have downloaded and tested on my own computer.

@zonuexe
Copy link
Member

zonuexe commented Aug 29, 2018

@fabacino Thank you, I also checked the display in my environment.

@zonuexe zonuexe merged commit 16b3f7c into emacs-php:master Aug 29, 2018
@fabacino fabacino deleted the bugfix/highlight-nullable-char branch August 29, 2018 06:05
@zonuexe zonuexe mentioned this pull request Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants