Skip to content

Commit

Permalink
ol-info: Use org function instead of subr-x
Browse files Browse the repository at this point in the history
* lisp/org-macs.el (org-unbracket-string): Handle empty suffix string.
* lisp/ol-info.el (org-info--link-file-node):
(org-info-description-as-command): Use `org-trim' and
`org-unbracket-string' instead of `string-trim' and
`string-remove-prefix' from the subr-x package.
  • Loading branch information
maxnikulin authored and yantar92 committed Sep 5, 2022
1 parent 1b647b0 commit 76a5f30
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
9 changes: 4 additions & 5 deletions lisp/ol-info.el
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@

;;; Code:

(require 'subr-x) ; `string-trim', `string-remove-prefix'
(require 'org-macs)
(org-assert-version)

Expand Down Expand Up @@ -78,11 +77,11 @@ File may be a virtual one, see `Info-virtual-files'."
'("dir" . "Top")
(string-match "\\`\\([^#:]*\\)\\(?:[#:]:?\\(.*\\)\\)?\\'" path)
(let* ((node (match-string 2 path))
;; Do not reorder, `string-trim' modifies match.
(file (string-trim (match-string 1 path))))
;; Do not reorder, `org-trim' modifies match.
(file (org-trim (match-string 1 path))))
(cons
(if (org-string-nw-p file) file "dir")
(if (org-string-nw-p node) (string-trim node) "Top")))))
(if (org-string-nw-p node) (org-trim node) "Top")))))

(defun org-info-description-as-command (link desc)
"Info link description that can be pasted as command.
Expand All @@ -106,7 +105,7 @@ If LINK is not an info link then DESC is returned."
(need-file-node (and (not (org-string-nw-p desc))
(string-prefix-p prefix link))))
(pcase (and need-file-node
(org-info--link-file-node (string-remove-prefix prefix link)))
(org-info--link-file-node (org-unbracket-string prefix "" link)))
;; Unlike (info "dir"), "info dir" shell command opens "(coreutils)dir invocation".
(`("dir" . "Top") "info \"(dir)\"")
(`(,file . "Top") (format "info %s" file))
Expand Down
3 changes: 2 additions & 1 deletion lisp/org-macs.el
Original file line number Diff line number Diff line change
Expand Up @@ -1101,7 +1101,8 @@ removed. Return the new string. If STRING is nil, return nil."
(and string
(if (and (string-prefix-p pre string)
(string-suffix-p post string))
(substring string (length pre) (- (length post)))
(substring string (length pre)
(and (not (string-equal "" post)) (- (length post))))
string)))

(defun org-strip-quotes (string)
Expand Down

0 comments on commit 76a5f30

Please sign in to comment.