Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential namespace conflict with ts.el #35

Closed
alphapapa opened this issue Apr 2, 2020 · 9 comments
Closed

Potential namespace conflict with ts.el #35

alphapapa opened this issue Apr 2, 2020 · 9 comments

Comments

@alphapapa
Copy link

Hi @ubolonton,

Following the recent discussions on emacs-devel, I saw you mention a ts-parse function. I can't find that function's definition in the master branch, but I do see some calls to it. So I thought I should mention that there is a potential namespace conflict with my library https://github.com/alphapapa/ts.el, which implements a ts-parse function.

Thanks for your work on this package. I'm looking forward to the improvements it will bring to Emacs.

@ubolonton
Copy link
Collaborator

Thanks for the kind words!

ts-parse is defined by the dynamic module here.

I think I'll rename it to something else, maybe ts-parse-chunks. It may be better if my package switches to another prefix, but I can't think of a satisfactory one currently.

@alphapapa
Copy link
Author

Naming things is hard. :) Thanks.

@sogaiu
Copy link
Contributor

sogaiu commented Apr 5, 2020

On a side note, does the tree-sitter-dyn.so that's mentioned here need to be updated to account for this change?

@ubolonton
Copy link
Collaborator

On a side note, does the tree-sitter-dyn.so that's mentioned here need to be updated to account for this change?

Yes, but I haven't uploaded the new version yet, since I intend to add a mechanism for the binaries to be versioned and downloaded separately first, so that the package as a whole can be published on MELPA.

Do you need this change soon?

@sogaiu
Copy link
Contributor

sogaiu commented Apr 6, 2020

Thanks for the status update.

Initially I didn't know how to build it and put the result in place, but that turned out to be doable, so I'm all set :)

Wanted to try the query builder and that now seems to work:

tree-sitter-query-builder-with-clojure

@shackra
Copy link
Collaborator

shackra commented May 15, 2020

Wanted to try the query builder

I made most of that feature for several months, any feed back? :D

@sogaiu
Copy link
Contributor

sogaiu commented May 15, 2020

Below are some things I noticed about the version I tried at the time of the screenshot (I went back and tried it again just now -- and I haven't updated since that time):

  • I thought it was helpful in making it clear what matched.
  • I've used it on one of Clojure's larger source files (core.clj 263653 bytes) and it seemed to perform without any difficulty so that's definitely nice.
  • The echo area was a bit noisy while the query is being constructed and not complete (Error: (rust-panic "called ...) etc.), but I can understand at this stage that it would be helpful to have that information (at least if you are the one developing the query builder).

Overall I think it is nice for testing out queries as well as for helping to interactively develop one's mental model of how tree-sitter queries work.

Thanks for making it!

@progfolio
Copy link

Two ideas for a unique namespace:

Short, practical -> "ets" for "emacs-tree-sitter"
Evocative -> "canopy" as in "where tree-sitters live"

@ubolonton
Copy link
Collaborator

Since 8e17490, the core APIs' prefix has been changed from ts- to tsc-.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants