Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matlab grammar #185

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Add matlab grammar #185

merged 1 commit into from
Jul 3, 2023

Conversation

acristoffers
Copy link
Contributor

No description provided.

@acristoffers acristoffers force-pushed the master branch 7 times, most recently from 89037f9 to 8f084e8 Compare June 18, 2023 14:25
@acristoffers
Copy link
Contributor Author

Ok, a lot of force-pushes later, I have what is considered the final version of the parser itself. I would like to know if there are changes that need to be made to the query file, as I'm currently using it and it works just fine, but I'm not familiar with the way your project handles those. I believed I have followed the instructions correctly, but I could not find a complete list of available query captures, so I don't if I missed something.

This parser was just accepted in Neovim (nvim-treesitter/nvim-treesitter#4944), and I mention that to show that, even though it is new, it went through a revision and got some changes and bug fixes already, and I consider it to be in a stable/release version. It will see bugfixes in the future, but not major changes.

@acristoffers acristoffers force-pushed the master branch 3 times, most recently from 2c53c6c to a2ada53 Compare June 23, 2023 19:09
@acristoffers
Copy link
Contributor Author

I got the queries from the elisp file, so now it should be 100% compliant.

@acristoffers acristoffers force-pushed the master branch 2 times, most recently from eea9ab7 to a2a7476 Compare June 24, 2023 10:53
@meain
Copy link
Member

meain commented Jun 26, 2023

Changes look good to me. Just wondering if we should do something about matlab-file-font-lock-keywords 🤔

@acristoffers
Copy link
Contributor Author

I set it to an empty list and it worked for me, but I must admit that I have no idea what that should actually be.

@acristoffers acristoffers force-pushed the master branch 5 times, most recently from 7f3a3f1 to 8bb494f Compare June 30, 2023 19:35
@acristoffers
Copy link
Contributor Author

In the last 2 force-pushes I bump the repo version because I fixed some bugs in the parser and also change the priority of the operators captures in highlight so single-quoted strings get highlighted correctly.

@meain
Copy link
Member

meain commented Jul 3, 2023

I set it to an empty list and it worked for me, but I must admit that I have no idea what that should actually be.

This is more of a matlab-mode problem, let me merge this in. Thanks for the PR and the grammar :D.

@meain meain merged commit 90e9cf9 into emacs-tree-sitter:master Jul 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants