New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
global-ts-fold-mode breaks evil folding for unsupported languages #3
Comments
You might want to enable (global-tree-sitter-mode 1) |
I have I just took a closer look -- |
Sorry for the late reply. Kinda got busy in a time. Ah, okay. I think the message |
It does do harm: it breaks Perhaps if it were |
I assumed you are talking about the fallback scenario? If that's the case, should
|
From what I can tell evil-fold is working as intended. I tried replacing
So to remedy this, we need some way to enable |
@eeshugerman I don't know if this is still relevant to spacemacs, but the commit above should correct the issue you were facing. Now, when |
This is possible now since emacs-tree-sitter/ts-fold#3 has been resolved.
This is possible now since emacs-tree-sitter/ts-fold#3 has been resolved.
@samrjack great news! As you can see above, I've opened a PR to take advantage of this in Spacemacs. Thanks for tackling this! |
This is possible now since emacs-tree-sitter/ts-fold#3 has been resolved.
If I enable
global-ts-fold-mode
and then try to use evil folding (evil-close-fold
) with an unsupported major mode (egsql-mode
), I getIs there some way this could be avoided?
Alternatively (or in addition), could
ts-fold
define (and autoload) a list of supported major modes?My specific use case is a Spacemacs layer (which I hope to get merged upstream) that (optionally) enables
ts-fold
for all supported languages -- ideally we wouldn't have to maintain that list in the layer. I imagine this would benefit many non-Spacemacs users as well, for basically the same reason.The text was updated successfully, but these errors were encountered: