Describe key

[andyjda]

See describe-key-README for a detailed overview of approach and trade-offs.

All the relevant code should be at the bottom of god-mode.el.
Be sure to check the portion of the README that I added.

Let me know if you have any questions or if you want me to make any changes

[darth10]

Also, this branch needs to be rebased on master, as there are commits from previous PRs showing up.

[andyjda]

• rebased. conflicts are gone
• removed custom variable god-translate-key-for-description
• reverted indentation

See my comments about the other proposed changes. If you can think of a good way to deal with the hooks/functions, let me know. I am not too familiar with their underlying implementation: to me it looks like the current approach is the simplest, but if there's a better one I am down to work on it

[darth10]

Thanks for putting in those changes @andyjda!
I've tested out the god-mode-describe-key function and it's looking good!

I've left a few more comments around supporting older Emacs versions (< 28.1).

[darth10]

Looks like you're using a combination of tabs and spaces for indentation.
You should be using only spaces, as described in the Emacs Lisp style guide.
I'd recommend using M-x untabify on these new functions, or even the entire file.

[andyjda]

Didn't know about the style, guide, thanks for letting me know!

[darth10]

help--key-description-fontified was added in Emacs 28.1, but God mode supports Emacs 25.1+.
You'll need a wrapper function around this form that checks (> emacs-major-version 27) to support older Emacs versions.

Reference: emacs-mirror/emacs@4a112fd

[darth10]

Suggested change

	;; due to how errors are passed,
	;; due to how errors are passed,

[andyjda]

I included all your proposed changes.
Let me know if there's anything else you'd like me to change. Thanks :)

[darth10]

Looks good! Thanks for the contribution again @andyjda.
Closes #144.