Flycheck patches #147
Merged
Flycheck patches #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darth10
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the
describe-keybranch, I noticed a couple of compilation warnings in other parts of the code.I figured it'd be better to have these "fixes" on a separate branch, to make it easier to compare.
Use keywords rather than deprecated positional arguments todefine-minor-mode'`help-keyis not used. I turned off the warning by adding the underscore to the name (signaling to the compiler that it'll be ignored). But someone who's more familiar with the code can maybe decide if it should be removed completely