Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by tangxinfa in a comment to the original describe-key issue, some times the advice and hook created within the
describe-key
function are not removed (as would be expected). This can cause errors down the line.This issue was caused by the fact that
was at the end of
god-mode-describe-key
, without taking into account that, in cases whengod-mode-describe-key
exits abnormally, this last part is never executed.The solution is to use the special form
unwind-protect
which allows us to specify "unwind-forms" that are always executed, even if the body of our function exits abnormally (see the documentation for more details)