Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete functions in Emacs 29.1 #208

Closed
arifer612 opened this issue Jan 4, 2024 · 2 comments · Fixed by #209
Closed

Obsolete functions in Emacs 29.1 #208

arifer612 opened this issue Jan 4, 2024 · 2 comments · Fixed by #209

Comments

@arifer612
Copy link
Contributor

In Emacs 29.1, the aliases point-at-bol and point-at-eol are obsolete, and
will raise warnings to use line-beginning-position/pos-bol, or
line-end-position/pos-eol, instead, respectively. While this is not a huge
issue at this moment, it might break the project if these aliases get deprecated
in the future. To avoid this from happening, the aliases should either:

  1. be re-defined in the project, or
  2. be replaced by the actual functions they reference, i.e.,
    line-beginning-position and line-end-position.

For legacy compatibility to around Emacs 20.4, using line-beginning-position
and line-end-position is the better choice.

I can work up a PR for this if nobody is against the idea of replacing the
aliases point-at-bol and point-at-eol to the fully qualified functions they
reference, line-beginning-position and line-end-position, respectively.
@conao3
Copy link
Collaborator

conao3 commented Jan 4, 2024

Nice catch. I am open to this change, can you create a PR?

arifer612 added a commit to arifer612/helm-swoop that referenced this issue Jan 4, 2024
@arifer612
replace obsolete aliases with fully qualified functions
a8aac95 
Replaced `point-at-bol` and `point-at-eol` with `line-beginning-position` and
`line-end-position`, respectively. Some style choices were made to break the
lines that got too long because of this change.

Closes emacsorphanage#208
@arifer612 arifer612 mentioned this issue Jan 4, 2024
Merged
@arifer612
Copy link
Contributor Author

Sure thing! Just put up the PR :)

@arifer612 arifer612 mentioned this issue Jan 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace obsolete aliases with fully qualified functions arifer612/helm-swoop
2 participants
@conao3 @arifer612