Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort helm-multi-swoop buffer candidate list #193

Merged
merged 11 commits into from
Aug 14, 2020
Merged

Sort helm-multi-swoop buffer candidate list #193

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3d7f852
use push instead of setq/cons combination
conao3 Aug 5, 2020
e7f3142
use string-trim instead of replace-regexp-in-string
conao3 Aug 5, 2020
5a66515
fix let structure
conao3 Aug 5, 2020
70bf353
bind after string-trim string
conao3 Aug 5, 2020
9b98da0
check word is empty when push into list
conao3 Aug 5, 2020
064aac0
use lst instead of list as let variable name
conao3 Aug 5, 2020
356c939
use dolist instaed of mapc to reduce indent level
conao3 Aug 5, 2020
3b8e437
use buffer-live-p instead of checking buffer existing
conao3 Aug 5, 2020
9df5247
use buf let variable instead of get-bufer each time
conao3 Aug 5, 2020
6adc76f
use cl-delete-if-not to redule when
conao3 Aug 5, 2020
fa744b4
sort entry
conao3 Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 13 additions & 17 deletions helm-swoop.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,23 +1078,19 @@ If LINUM is number, lines are separated by LINUM."
(defun helm-multi-swoop--get-marked-buffers ()
"Get marked buffers."
(let ((buf (get-buffer helm-multi-swoop-buffer-list))
list)
(when buf
(with-current-buffer (get-buffer helm-multi-swoop-buffer-list)
(mapc (lambda (ov)
(when (eq 'helm-visible-mark (overlay-get ov 'face))
(setq list (cons
(let ((word (buffer-substring-no-properties
(overlay-start ov) (overlay-end ov))))
(mapc (lambda (r)
(setq word (replace-regexp-in-string
(car r) (cdr r) word)))
(list '("\\`[ \t\n\r]+" . "")
'("[ \t\n\r]+\\'" . "")))
word)
list))))
(overlays-in (point-min) (point-max))))
(delete "" list))))
lst)
(when (buffer-live-p buf)
(with-current-buffer buf
(dolist (ov (cl-delete-if-not
(lambda (o)
(eq 'helm-visible-mark (overlay-get o 'face)))
(overlays-in (point-min) (point-max))))
(let ((word (string-trim
(buffer-substring-no-properties
(overlay-start ov) (overlay-end ov)))))
(unless (string-empty-p word)
(push word lst)))))
(nreverse (sort lst #'string<)))))

;; core --------------------------------------------------------

Expand Down