libgit.el: Be able to load libegit2 from load-path if found

[Thaodan]

Prefer previously installed libegit2 but check first for libegit2 from
load-path if it wasn't build already.

I modeled this logic similarly as in Jinx or ZMQ.el

I'm going to package libgit, loading it from load-parh allows to prebuild libegit.so without patching the package.

[Thaodan]

I just noticed that earlier that we build so because
before Emacs 28 module-suffix was so on MacOS.

Would it make sense to override the suffix for Emacs <28
on MacOS?

[tarsius]

Thanks, that sounds useful. I am still quite busy, so it will probably be a week until I get around to reviewing this.

[Thaodan]

Thanks, that sounds useful. I am still quite busy, so it will probably be a week until I get around to reviewing this.

No problem. If you can meanwhile give a comment on my comment above that would be great.

[tarsius]

If you can meanwhile give a comment on my comment above that would be great.

Sure, but I am afraid the answer is "I have no idea".

[tarsius]

As you (but not others) know, there is/was some related talk in 77bd28a.

[Thaodan]

I submitted libgit using these patches to openSUSE:
https://build.opensuse.org/package/show/editors/emacs-libgit2

[tarsius]

IMO that was premature. You only opened this pull-request two weeks ago, and I have not rejected it. Sure, in an ideal world I would have reviewed it by now, but alas I was too busy for that. It seems to me, that by suggesting to the opensuse maintainers to apply these patches, you are just causing them more work. If they prioritize working on your proposal, then other things will get delayed. I.e., you are making the world a little less ideal, by generating work, which could likely be avoided altogether, just by being a bit more patient.

[Thaodan]

I'm sorry I didn't mean to create an pressure on your side. I submitted the package to SUSE, it did not exist before and will maintain the package. I did patch the package earlier to load the native module correctly, as policy patches should be if possible submitted to upstream. My indent was to use patches that can be accepted into the upstream inside the package. I had to patch the package to correctly load the native module from the correct directory (libdir). I will update the package with any updates regarding this patch when needed. Again sorry for the friction created.

[tarsius]

I submitted the package to SUSE, it did not exist before and will maintain the package.

Ah, sorry I didn't realize that.

I did patch the package earlier to load the native module correctly, as policy patches should be if possible submitted to upstream.

So you did everything right. Maybe a little too much in a hurry, but that's okay.

Again sorry for the friction created.

It's all good. And sorry for overlooking some important detail. ;P

[tarsius]

Thanks!