Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add twitter/bootstrap theme support #28

Closed
xiaohanyu opened this issue Mar 18, 2013 · 4 comments
Closed

add twitter/bootstrap theme support #28

xiaohanyu opened this issue Mar 18, 2013 · 4 comments

Comments

@xiaohanyu
Copy link
Contributor

twitter/bootstrap provides some concise css/javascript solution.

I'll try to add this in a few weeks.

@sillykelvin
Copy link
Collaborator

Thanks for your attention. As I mentioned in issue [#29], please consider variable name change when you are making themes. The variables are extracted from org-page.el, into op-vars.el on branch devel.

@ic3guy
Copy link

ic3guy commented Feb 23, 2014

I think this would be a good place to ask a quick question. Why is there a (defcustom template-directory ...) but no (defcustom theme-directory ...). Was it just a design decision to force themes to be install in "org-page-base/themes/...".

The change might be to replace calls to (op/get-theme-dir) to just get the theme-dir directory defined as a variable. Does this make sense?

@sillykelvin
Copy link
Collaborator

Good question, I did not realize this inconsistency until you pointed out. I will evaluate the possibility of changing op/get-theme-dir into variable, and it may be implemented later.

@sillykelvin
Copy link
Collaborator

Implemented, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants