Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process of contribution #19

Open
husseinalhammad opened this issue Sep 29, 2021 · 2 comments
Open

Process of contribution #19

husseinalhammad opened this issue Sep 29, 2021 · 2 comments
Assignees
Labels
meta Relates to operation of the group itself

Comments

@husseinalhammad
Copy link
Member

During the 2021-09-29 call, @avigoldman asked about the process of contribution and who can do what. I think it's clear that we don't have well-defined processes/rules yet. @M-J-Robbins also pointed out that it could be useful to define some roles for the separate projects we work on.

I think the only thing we agreed on in this regard so far is to make it mandatory for another member to approve a PR before merging here.

Common approaches in open source:

@husseinalhammad husseinalhammad added the meta Relates to operation of the group itself label Sep 29, 2021
@M-J-Robbins
Copy link
Member

Just thinking as I put up a PR, should we add some guidance on who to tag to review a PR.
I feel like tagging everyone is too spamming, but also don't want to exclude people.

@husseinalhammad
Copy link
Member Author

Perhaps we need one or two people to be in charge of general house keeping*. Part of their role can be reviewing PRs. They can be the ones to be tagged as reviewers by default. They can then decide who's best to review and approve the PR (if not them) and tag them to review.

*We're sort of collectively trying to do this right now. Contribution here doesn't have to be in writing code or documentation. Keeping the whole group organised and keeping tabs on the various projects would be very helpful and valuable to us.


@dylanatsmith also shared some comments on Slack about GitHub code reviews that may be relevant here.

@husseinalhammad husseinalhammad self-assigned this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Relates to operation of the group itself
Projects
None yet
Development

No branches or pull requests

2 participants