Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update key name from 'user_id' to 'public_key' #issue38 #37

Closed
wants to merge 1 commit into from

Conversation

azazack
Copy link

@azazack azazack commented Jul 21, 2022

the issue is its still uses a user_id params after being update to public key three month
Screen Shot 2022-07-21 at 13 30 40
Screen Shot 2022-07-21 at 13 31 27

@azazack azazack changed the title fix: update key name from 'user_id' to 'public_id' fix: update key name from 'user_id' to 'public_key' Jul 21, 2022
@azazack azazack changed the title fix: update key name from 'user_id' to 'public_key' fix: update key name from 'user_id' to 'public_key' #issue38 Jul 21, 2022
@azazack
Copy link
Author

azazack commented Sep 25, 2022

@arnonrdp can you merge it ? thanks.

@arnonrdp
Copy link

Sorry, I am not part of the team.
I just reviewed and approved your PR to confirm that we NEED this improvement.

@xr0master
Copy link
Contributor

At the moment the code works correctly, I will close this PR. Thanks for your cooperation.

@xr0master xr0master closed this Sep 27, 2022
@azazack
Copy link
Author

azazack commented Sep 27, 2022

@xr0master can you double check please ? me and @arnonrdp we are facing the same issue, and i shared the screen with you.

@xr0master
Copy link
Contributor

Yes, I am 100% sure. If you have an issue, it definitely does not relate to the operation of the SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants