Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chongye's code modification and galaxy model finishing toches #21

Merged
merged 3 commits into from
Dec 17, 2022

Conversation

emapco
Copy link
Owner

@emapco emapco commented Dec 17, 2022

  • Add Chongye's plotting and logging code.

    • Essentially as is but compatible with templated class.
    • Move create_log from init_condition to setup_dimensions_Xd since setup is only called once but user can call init_condition multiple times
  • Add physics equations required by our galaxy model.

    • Model seems to work.
    • No memory issues

This was linked to issues Dec 17, 2022
@trevoroldham
Copy link
Collaborator

Merging this so I can copy and submit

@trevoroldham trevoroldham merged commit a7d1e33 into main Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Galaxy model physics-related functions Output data structure
2 participants