Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve keep_audio and keep_video API #26

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

sleepycatcoding
Copy link
Contributor

@sleepycatcoding sleepycatcoding commented May 12, 2023

Makes keep_video and keep_audio API more useful by allowing consumer to specifiy paths where files should be saved.

TODO

  • Update documentation

@emarsden
Copy link
Owner

Thanks, the general principle looks good to me.

A nitpick, perhaps the "Other" error could be made an IoError with a reason similar to "requested audio path is invalid UTF-8"?

@sleepycatcoding
Copy link
Contributor Author

sleepycatcoding commented May 16, 2023

The problem of making it a IoError is that we need a std::io::Error object.

dash-mpd-rs/src/lib.rs

Lines 106 to 107 in 6a73f89

#[error("I/O error {1}")]
Io(#[source] std::io::Error, String),

@emarsden emarsden marked this pull request as ready for review June 15, 2023 10:39
@emarsden emarsden merged commit 2a3086f into emarsden:main Jun 15, 2023
@emarsden
Copy link
Owner

OK, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants