feat(@embark/core): Support directives in ENS config #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support directives in ENS configurations, such that subdomains can be registered to addresses of deployed tokens.
The following directives are supported:
```
"register": {
"rootDomain": "embark.eth",
"subdomains": {
"status": "0x4a17f35f0a9927fb4141aa91cbbc72c1b31598de",
"mytoken": "$MyToken",
"MyToken2": "$MyToken2"
}
}
```
Add unit test for these directives.
alaibe
approved these changes
Dec 6, 2018
jrainville
reviewed
Dec 7, 2018
| if (directives && directives.length) { | ||
| this.embark.registerActionForEvent("contracts:deploy:afterAll", async (deployActionCb) => { | ||
| this.events.request("contracts:contract", directives[1], (contract) => { | ||
| if(!contract) return deployActionCb(); // if the contract is not registered in the config, it will be undefined here |
There was a problem hiding this comment.
You should print a warning so that the user knows that he tried to register something to an address we don't know about.
|
We shouldn't forget to add documentation for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support directives in ENS configurations, such that subdomains can be registered to addresses of deployed tokens.
The following directives are supported:
Add unit test for these directives.