fix(@embark/cockpit): Switching between tabs resets logs #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
approved these changes
Mar 7, 2019
alaibe
approved these changes
Mar 7, 2019
jrainville
approved these changes
Mar 7, 2019
| @@ -111,14 +111,15 @@ class EmbarkController { | |||
| }); | |||
| }, | |||
| function (callback) { | |||
| engine.startService("embarkListener"); | |||
There was a problem hiding this comment.
Why was this switched around?
There was a problem hiding this comment.
Great question. The EmbarkListener is responsible for listening to any logging output of embark. Because the EmbarkListener was started later in the lifecycle, there were a few logs that were not being captured, and thus the cockpit log output looked a little bit incomplete. I tried to move this above embark.init, but it wasn't happy. You'll notice the only missing logs in the cockpit now are the Welcome to embark at the top.
I will move the engine.startService("embarkListener"); to inside the embark.init callback to try to get all of the missing logs included.
Switching between the two tabs shown on the Dashboard for the cockpit was removing some of the logs that were previously displayed. This was due to an overlap in `id`’s being assigned to the logs from different processes. To alleviate this, the reducers has been updated to not only check `id` but also `process.name`. Additionally, the reducer was updated so that the number of logs for **each process** is set to `ELEMENTS_LIMIT`. For example, our `ELEMENT_LIMIT` is currently set to `200` and it would have meant that the total number of process logs across all processes would have been capped at 200. The current changes in this PR allow for 400 total logs, given that we have two processes being monitored for logs.
emizzle
force-pushed
the
fix/cockpit/disappearing-logs
branch
from
827949f
to
b11a90e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching between the two tabs shown on the Dashboard for the cockpit was removing some of the logs that were previously displayed. This was due to an overlap in
id’s being assigned to the logs from different processes.To alleviate this, the reducers has been updated to not only check
idbut alsoprocess.name.Additionally, the reducer was updated so that the number of logs for each process is set to
ELEMENTS_LIMIT. For example, ourELEMENT_LIMITis currently set to200and it would have meant that the total number of process logs across all processes would have been capped at 200. The current changes in this PR allow for 400 total logs, given that we have two processes being monitored for logs.