Display warning for gas price #872
Conversation
lib/tests/test.js
Outdated
| cb(); | ||
| }); | ||
| } | ||
|
|
||
| showNodeHttpWarning() { | ||
| if (this.options.node.startsWith('http')) { | ||
| this.engine.logger.warn("You are using http to connect to the node, as a result the gas details won't be correct"); |
There was a problem hiding this comment.
Could we maybe add a possible solution for the user? For example,
You are using http to connect to the node, as a result the gas details won't be correct. For correct gas details reporting, please use a websockets connection to your node.
What do you think of this?
There was a problem hiding this comment.
Much better indeed, I updated the text
|
When running |
|
@michaelsbradleyjr it will default to use web socket and no warning will be printed in that case |
|
When running |
|
This is because the demo is configure to use http and not websocket. using Does that make sense? |
|
Makes perfect sense, thanks. I guess what I'm wondering is if in the case of |
|
I guess what you are suggesting is almost a new option: @iurimatias what do you think? |
|
|
|
Gotcha (I think). There is another way. Change the demo config to use websocket for contract deployment: That way there will be no warning |
|
That would work. What do you think @iurimatias, should we update the templates? |
|
I agree it should be changed in the template, I thought it was already the default in fact |
Overview
TL;DR
Display a warning when gas price won't be display
Cool Spaceship Picture