fix: only one of today's and tomorrow's prayerCard is highlighted #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stormix
requested changes
Aug 23, 2023
| @@ -20,6 +20,7 @@ module.exports = { | |||
| ], | |||
| rules: { | |||
| 'react/jsx-uses-react': 'off', | |||
| 'react/react-in-jsx-scope': 'off' | |||
| 'react/react-in-jsx-scope': 'off', | |||
| '@typescript-eslint/no-explicit-any': 'off' | |||
There was a problem hiding this comment.
So i can create my beautiful baby Fixtype
| @@ -0,0 +1 @@ | |||
| export type FixType = any; | |||
| nextPrayerToday ? todayPrayerTimes[nextPrayerToday] : tomorrowPrayerTimes[nextPrayerTomorrow] | ||
| ) as Date; | ||
| let nextPrayer = nextPrayerToday; | ||
| let nextPrayerTime: FixType = nextPrayerToday ? todayPrayerTimes[nextPrayerToday] : null; |
There was a problem hiding this comment.
Use keyof adhan.PrayerTimes | null instead of FixType.
There was a problem hiding this comment.
Already tested :)
Type 'Coordinates' is not assignable to type 'keyof PrayerTimes | null'.ts(2322)
I "any" it for now because no time for it, otherwise i'll take a close look at it asap.
|
Fixed in a separate commits. Thank you for your contribution! |
|
@all-contributors please add @smehdii for code and ideas |
|
I've put up a pull request to add @smehdii! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2