Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Introduce IoctlType enum for IOCTL types #15

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Sep 11, 2022

This commit introduces an enum to represent the IOCTL command types
available, the direction of the data transfer (Get and Set).

@Dirbaio
Copy link
Member

Dirbaio commented Sep 21, 2022

The enum IoctlHeader naming is a bit weird: this is not a header, it's just a field within a header.

Also I'm not sure the names for the values are right? WHD calls it the "type", and the values are 0x00 = get, 0x02 = set. https://github.com/Infineon/wifi-host-driver/blob/master/WiFi_Host_Driver/src/include/whd_cdc_bdc.h#L55

@danbev
Copy link
Contributor Author

danbev commented Sep 22, 2022

The enum IoctlHeader naming is a bit weird: this is not a header, it's just a field within a header.

Yeah, I went back and forth on that, I had it named IoctlHeaderType but changed it for some reason.

Also I'm not sure the names for the values are right?

Hmm, I thought I had got those right but let me take another look and see if I've made a mistake. Thanks

This commit introduces an enum to represent the IOCTL command types
available, the direction of the data transfer (Get and Set).
@danbev danbev changed the title Introduce IoctlHeader enum for ioctl header types Introduce IoctlType enum for IOCTL types Sep 22, 2022
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Dirbaio Dirbaio merged commit 9db9333 into embassy-rs:master Sep 22, 2022
@danbev
Copy link
Contributor Author

danbev commented Sep 22, 2022

@Dirbaio Sorry about this, I had a look and I completely messed this up and confused it with the ioctl channel type 😞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants