Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32: add timeout to I2C driver #2033

Merged
merged 16 commits into from
Oct 12, 2023

Conversation

andresovela
Copy link
Contributor

No description provided.

embassy-stm32/Cargo.toml Outdated Show resolved Hide resolved
@andresovela
Copy link
Contributor Author

Finally! Made CI happy. I'm not very happy with all the guards everywhere now, but I guess that's what needs to be done? Let me know if you know of better solutions.

@andresovela andresovela requested a review from lulf October 11, 2023 21:55
Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! Could you perhaps add at least one chip build to ci.sh that tried to build embassy-stm32 without time so it doesn't bit-rot?

@andresovela
Copy link
Contributor Author

Done

@lulf lulf added this pull request to the merge queue Oct 12, 2023
Merged via the queue into embassy-rs:main with commit 01eb1a7 Oct 12, 2023
4 checks passed
@andresovela andresovela deleted the stm32-add-timeout-to-i2c branch October 12, 2023 22:14
@chemicstry
Copy link
Contributor

Unfortunatelly this removed timeout feature from i2c_v1 🫤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants