Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove portable-atomic #2242

Merged
merged 1 commit into from
Mar 1, 2024
Merged

remove portable-atomic #2242

merged 1 commit into from
Mar 1, 2024

Conversation

lz1998
Copy link
Contributor

@lz1998 lz1998 commented Dec 3, 2023

No description provided.

@Dirbaio
Copy link
Member

Dirbaio commented Dec 3, 2023

what's the rationale for removing it? Is it because rust-lang/rust#114499 is now merged, or is it something else?

If it's the former, we can't remove portable-atomic yet. When Rust 1.75 is released at the end of the month, Embassy will switch to fully supporting stable, and that PR won't be released until Rust 1.76.

@Dirbaio Dirbaio mentioned this pull request Dec 5, 2023
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.76 has been out of a while, we can merge this now. i've rebased it for you.

Thanks for the PR!

@Dirbaio Dirbaio enabled auto-merge March 1, 2024 23:23
@Dirbaio Dirbaio added this pull request to the merge queue Mar 1, 2024
Merged via the queue into embassy-rs:main with commit 6489049 Mar 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants