Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf: add NVMC driver. #444

Merged
merged 1 commit into from
Oct 23, 2021
Merged

nrf: add NVMC driver. #444

merged 1 commit into from
Oct 23, 2021

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Oct 22, 2021

I haven't implemented embassy_traits::Flash because I want to change it to match embedded_storage, which is much better designed.

Either way, NVMC can't do async anyway, so the best we could do is implementing the async trait in a blocking way...

Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think the API is nice, code looks good as always!

@lulf
Copy link
Member

lulf commented Oct 23, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 23, 2021

Build succeeded:

@bors bors bot merged commit f3f3858 into master Oct 23, 2021
@Dirbaio Dirbaio deleted the nrf-nvmc branch October 28, 2021 02:00
@Dirbaio Dirbaio mentioned this pull request Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants