Add critical-section/std to std feature #941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit suggests adding
critical-section/std
to the std feature aswithout this a link time error is generated:
I ran into this when updating an example project I have to use
embassy-executor
.Reproduce
Create a new project:
Update
Cargo.toml
:Notice the commented out
critical-section
dependency which will produces the link error.Update
src/main.rs
with the code from embassy.dev/dev/examples.html:Running the example:
$ cargo r