This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Allow custom board implementations for sx1261/2 and sx1276/7/8/9 #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom board and chip types to allow users to implement external RadioKind and InterfaceVariant traits for a custom (perhaps proprietary) sx1261/2-based or sx1276/7/8/9-based LoRa board. Use those implementations underneath the standard LoRa API. For example:
This PR partially addresses Issue #13.
Complete freedom to use a LoRa chip unknown to lora-phy will require a new major release, since the implementations of modulation and packet parameter creation contain logic specific to the radio kind, but is not currently implemented within the RadioKind trait. An update to the RadioKind trait will necessitate a new major release.