Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ScanParams #54

Merged
merged 2 commits into from
Feb 3, 2021
Merged

add ScanParams #54

merged 2 commits into from
Feb 3, 2021

Conversation

rise0chen
Copy link
Contributor

add ScanParams for central

@rise0chen rise0chen mentioned this pull request Jan 29, 2021
Closed
@rise0chen
Copy link
Contributor Author

How about replace ScanParams::filter_policy by addresses: [&Address]?
filter_policy is BLE_GAP_SCAN_FP_ACCEPT_ALL when addresses.len() == 0, else is BLE_GAP_SCAN_FP_WHITELIST.

@Dirbaio
Copy link
Member

Dirbaio commented Feb 3, 2021

Thanks for the PR!

Yes, the filter_policy field is somewhat redundant with the addresses, but I'll merge it as-is and tweak it myself. (I need coded phy in central too actually!)

@Dirbaio Dirbaio merged commit a7508c0 into embassy-rs:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rise0chen @Dirbaio