Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Excel Loader to load .xlsx #1145

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eren-darici
Copy link

@eren-darici eren-darici commented Jan 8, 2024

Description

  • Excel Loader created
  • Dependencies added
  • Basic tests are created

How Has This Been Tested?

  • Created test_excel.py which includes multi-sheet validation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes most issues related Excel
  • Made sure Checks passed

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 8, 2024
Copy link
Collaborator

@deshraj deshraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. Left a minor comment.

Thanks for the contrbution. ❤️ 🚀

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@deven298 deven298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments. Thanks for adding this btw! ❤️

embedchain/loaders/excel.py Show resolved Hide resolved
embedchain/loaders/excel.py Outdated Show resolved Hide resolved
@deven298
Copy link
Contributor

LGTM!

@eren-darici Could you please resolve the conflicts? Also, it would be great it you can add docs for this here.
I will merge this and release it in next package release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants