Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redis vectordb #1231

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tylerhutcherson
Copy link

@tylerhutcherson tylerhutcherson commented Jan 30, 2024

Description

This PR includes Redis as a vector database to Embedchain using the new, purpose-built redisvl python library. Given work was already started using base redis-py, I wanted to also highlight the work started here (#756) by @SudhanshuJoshi09. This simplifies the codebase a good bit (for redis) and also includes more explicit metadata filtering via "Tag" fields in Redis. It also updates documentation, adds an example notebook, and config examples.

FYI @deshraj I'd love to get any additional feedback here. The version of redisvl used to build this will be released later this week (so I am tied to a github branch atm). But I wanted to get a head start.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 30, 2024
@tylerhutcherson
Copy link
Author

Hi @deshraj @taranjeet We are interested in getting this merged soon if possible. What else is required? I've pinned to a supported version of redisvl and updated tests and contributed docs and notebook examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant