Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Set a default app id if not provided in the app configuration #1300

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

deshraj
Copy link
Collaborator

@deshraj deshraj commented Mar 2, 2024

Description

Several folks have mentined this issue that their app data is not persisted when they init the app using app = App().

This is because we were setting a new app id every time someone does an init. We are changing this behavior to set a default app id unless user specifically configures it in their app configuration during init time.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.85%. Comparing base (7e1d2ff) to head (8f8a0cb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
- Coverage   55.85%   55.85%   -0.01%     
==========================================
  Files         153      153              
  Lines        6171     6170       -1     
==========================================
- Hits         3447     3446       -1     
  Misses       2724     2724              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deshraj deshraj merged commit faacfeb into main Mar 2, 2024
5 checks passed
@deshraj deshraj deleted the user/dyadav/set-default-app-id branch March 2, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant