Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LanceDB Integration #1320

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

PrashantDixit0
Copy link

@PrashantDixit0 PrashantDixit0 commented Mar 16, 2024

Description

This PR adds LanceDB vector database.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I have written tests for the LanceDB vector database in tests/vectordb/test_lancedb.py

  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@AyushExel
Copy link

hey guys can we let this reviewed? Thanks!

@LeonieFreisinger
Copy link
Contributor

@PrashantDixit0 thanks for proposing these changes. I had a look at your code. There are 2 minor problems with the imports.
embedchain/config/vectordb/lancedb.py:
please correct the import line to
from embedchain.helpers.json_serializable import register_deserializable

tests/vectordb/test_lancedb.py:
please correct import line to:

from embedchain.config import AppConfig
from embedchain.config.vectordb.lancedb import LanceDBConfig

Further, lancedb is not yet added to the factory.py and the misc.py. Can you add this?

@PrashantDixit0
Copy link
Author

PrashantDixit0 commented May 17, 2024

@LeonieFreisinger Thank you for highlighting it, I have added these changes. Is it now good to merge?

@LeonieFreisinger
Copy link
Contributor

@PrashantDixit0 What example did you use to test your code? Can you provide me with a quick example and a sample config? Thanks.
Could you also add an example to the docs?

@PrashantDixit0
Copy link
Author

Sure @LeonieFreisinger, I'll add an example notebook in notebooks folder

@PrashantDixit0
Copy link
Author

@LeonieFreisinger, I have added an example notebook and tested the whole flow. Is it good to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants