Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added unit tests for DocsSiteLoader (embedchain#698) #1332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

t8210103
Copy link

Description

Added a test method that ensures that the test_load_data_get_all_urls method of the test_docs_side_loader class behaves as expected

Fixes #698

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@LeonieFreisinger
Copy link
Contributor

@t8210103 Thanks for providing the additional test. I reviewed and ran your code locally. Looks good to me. The CI pipeline is failing due to a lint error. Can you please check line 254 in tests/loaders/test_docs_site_loader.py. The line is too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test coverage of embedchain/vectordb/elasticsearch.py
2 participants