Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to extract timestamps from youtube videos #1345

Merged
merged 7 commits into from May 6, 2024

Conversation

Esparon1
Copy link
Contributor

@Esparon1 Esparon1 commented Apr 22, 2024

Description

This PR introduces a new feature to extract timestamps from youtube videos and store them with other metadata elements .
This enhancement aims to provide richer data insights and improve content navigation and usability.

Fixes # (#1244)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manual testing was conducted to ensure the accuracy and reliability of the timestamp extraction. Tests included videos of various lengths and formats to verify that the timestamps are correctly identified and recorded.

Example of timestamps added to metadata
image

and this is an example of the transcript format which is generated:
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

Copy link
Collaborator

@deshraj deshraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good in general.

embedchain/loaders/youtube_video.py Outdated Show resolved Hide resolved
embedchain/loaders/youtube_video.py Outdated Show resolved Hide resolved
embedchain/loaders/youtube_video.py Outdated Show resolved Hide resolved
@deshraj deshraj merged commit 78301ee into embedchain:main May 6, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants