Added language detection for non-english youtube videos #1362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Invoking
app.add()
on non-english youtube videos would cause aNoTranscriptFound
error. There is already a pull request that fixes the issue by specify an additional argument in the config file, but it has not been merged until today. Ideallyapp.add()
also automatically detects the language in the youtube transcript, instead having to manually specify the language in the beginning.Fixes #385
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I simply invoked
app.add()
on various non-english youtube videos, and theNoTranscriptFound
error no longer appears.Please delete options that are not relevant.
Checklist:
Maintainer Checklist