Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output associated type to Drawable #552

Merged
merged 4 commits into from
Feb 16, 2021
Merged

Conversation

jamwaffles
Copy link
Member

@jamwaffles jamwaffles commented Feb 15, 2021

Thank you for helping out with embedded-graphics development! Please:

  • Check that you've added passing tests and documentation
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public API
  • Run rustfmt on the project
  • Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description

Perhaps a very little interpretation of #548, but here's my go at a return type for Drawable.

Closes #548

Copy link
Member

@rfuest rfuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for a few small doc nits.

MIGRATING-0.6-0.7.md Outdated Show resolved Hide resolved
core/CHANGELOG.md Outdated Show resolved Hide resolved
core/src/drawable.rs Show resolved Hide resolved
@jamwaffles
Copy link
Member Author

All good points - changes made in the most recent commit.

MIGRATING-0.6-0.7.md Outdated Show resolved Hide resolved
MIGRATING-0.6-0.7.md Outdated Show resolved Hide resolved
Co-authored-by: Ralf Fuest <mail@rfuest.de>
Copy link
Member

@rfuest rfuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamwaffles jamwaffles merged commit f52ee36 into master Feb 16, 2021
@jamwaffles jamwaffles deleted the drawable-return-type branch February 16, 2021 17:10
@jamwaffles
Copy link
Member Author

Thanks!

@bugadani
Copy link
Member

OMG I think this just made it possible to support flowing text into different textboxes. Need to think about it some more but the possibilities...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add return type to Drawable::draw
3 participants