Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reset methods to builders #576

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Add reset methods to builders #576

merged 1 commit into from
Apr 6, 2021

Conversation

rfuest
Copy link
Member

@rfuest rfuest commented Apr 2, 2021

This PR adds the reset methods to builders, that were discussed in #554.

Closes #554

@rfuest rfuest requested a review from jamwaffles April 2, 2021 15:23
jamwaffles
jamwaffles requested changes Apr 6, 2021
View reviewed changes
Copy link
Member

@jamwaffles jamwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although it's missing a changelog entry.

@rfuest
Copy link
Member Author

rfuest commented Apr 6, 2021

OK, I've added the missing changelog entry.

@rfuest rfuest requested a review from jamwaffles April 6, 2021 15:30
jamwaffles
jamwaffles approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@jamwaffles jamwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good to go :)

@rfuest rfuest merged commit 1ba6bf4 into embedded-graphics:master Apr 6, 2021
@rfuest rfuest deleted the builder-reset branch April 6, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamwaffles jamwaffles jamwaffles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add methods to reset settings in builders
2 participants
@rfuest @jamwaffles